Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge): testimonials + bridge now sections #17

Merged
merged 25 commits into from
Feb 20, 2024

Conversation

dohaki
Copy link
Collaborator

@dohaki dohaki commented Feb 16, 2024

Closes ACX-1890 and ACX-1891

Copy link

linear bot commented Feb 16, 2024

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
across-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 6:42am

@dohaki dohaki changed the title feat(bridge): tweet testimonials section feat(bridge): testimonials + bridge now sections Feb 16, 2024
Copy link

linear bot commented Feb 16, 2024

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits

Comment on lines +39 to +47
<>
Yeah, I bridge a lot, noticed @BungeeExchange routes were giving me
@AcrossProtocol most of the time, so just started to use it as my default bridge
(minimizing risk is my primary concern when bridging).
<br />
<br />
Transfers are incredibly fast and cheap. Great work!
</>
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'm not a huge fan of having markdown for each individual tweet. Not sure if there's a better solution, but it feels like it may be unwieldy if we increase the number of tweets.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I am also not a big fan of this. But that's the best I could come up with. Especially with the Twitter API being highly limited (free version at least)

Comment on lines +4 to +11
remotePatterns: [
{
protocol: "https",
hostname: "pbs.twimg.com",
pathname: "**",
},
],
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Base automatically changed from bridge-hero-and-feats to master February 20, 2024 06:40
@dohaki dohaki merged commit 321464d into master Feb 20, 2024
4 checks passed
@dohaki dohaki deleted the bridge-testimonials-section branch February 20, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants